[RWL] Grafiken und GameFonts

[KJ_Jansson]

Hi melcher kürzer!

Here Gamefonts for your mod. I made all changes you required.

Please, try and report your results. Today I will be on forum again and probably a number of corrections will be required before your Gamefonts will work correctly.

Could you, please, also backup and upload here on forum your defected Gamefonts. Your Gamefonts contain something (???) that requires a shift on ONE line, but the shift in OPPOSITE DIRECTION!

I would like to catch the reason of it, if I could, of course.... Thank you very much in advance.

[melcher kürzer]

Hi melcher kürzer!

Here Gamefonts for your mod. I made all changes you required.

Please, try and report your results. Today I will be on forum again and probably a number of corrections will be required before your Gamefonts will work correctly.

Thanks KJ!
Your alpha channel (and therefore the quality is much better then mine).
But i get the exact same error.

I have noticed some things:
- I tried your long gamefont. With that one most of the icons are displayed correctly. But the dot in 9th line (counting from the yield line) right next to the civ4 green illness face is the last one that works. The strength icon is missing and the movment number looks strange. Also there are some text errors.

With your, mine and the TAC gamefont:
- In the advisor screen the last yield is missing (diamond) under production and warehouse.

Could you, please, also backup and upload here on forum your defected Gamefonts. Your Gamefonts contain something (???) that requires a shift on ONE line, but the shift in OPPOSITE DIRECTION!

I would like to catch the reason of it, if I could, of course.... Thank you very much in advance.

Sure, but i think the error has nothing to do with my gamefont.
Maybe an .dll or xml error?
I give you a quick overview what i have done so far.

.dll

Achtung Spoiler:

CvEnums.h

	YIELD_FOOD,
	YIELD_LUMBER,
	YIELD_SILVER,
	YIELD_GOLD,		//melcher new resource
	YIELD_COCOA,  //ray17
	YIELD_COTTON,
	YIELD_FUR,
	YIELD_SUGAR,
	YIELD_TOBACCO,
	YIELD_WHALE_BLUBBER, //TAC Whaling, ray
	YIELD_ORE,
	YIELD_CLOTH,
	YIELD_COATS,
	YIELD_RUM,
	YIELD_CIGARS,
	YIELD_WHALE_OIL, //TAC Whaling, ray
	YIELD_TOOLS,
	YIELD_MUSKETS,
	YIELD_HORSES,
	YIELD_TRADE_GOODS,
	YIELD_LUXURY_GOODS,		//melcher new resource
	YIELD_CULTURE,		//melcher new resource
	YIELD_HAMMERS,
	YIELD_BELLS,
	YIELD_CROSSES,
	YIELD_EDUCATION,

CyEnumsInterface.cpp

		.value("NO_YIELD", NO_YIELD)
		.value("YIELD_FOOD", YIELD_FOOD)
		.value("YIELD_LUMBER", YIELD_LUMBER)
		.value("YIELD_SILVER", YIELD_SILVER)
		.value("YIELD_GOLD", YIELD_GOLD)   //melcher  new resource
		.value("YIELD_COCOA", YIELD_COCOA) //ray17
		.value("YIELD_COTTON", YIELD_COTTON)
		.value("YIELD_FUR", YIELD_FUR)
		.value("YIELD_SUGAR", YIELD_SUGAR)
		.value("YIELD_TOBACCO", YIELD_TOBACCO)
		.value("YIELD_WHALE_BLUBBER", YIELD_WHALE_BLUBBER) //TAC Whaling, ray
		.value("YIELD_ORE", YIELD_ORE)
		.value("YIELD_CLOTH", YIELD_CLOTH)
		.value("YIELD_COATS", YIELD_COATS)
		.value("YIELD_RUM", YIELD_RUM)
		.value("YIELD_CIGARS", YIELD_CIGARS)
		.value("YIELD_WHALE_OIL", YIELD_WHALE_OIL) //TAC Whaling, ray
		.value("YIELD_TOOLS", YIELD_TOOLS)
		.value("YIELD_MUSKETS", YIELD_MUSKETS)
		.value("YIELD_HORSES", YIELD_HORSES)
		.value("YIELD_TRADE_GOODS", YIELD_TRADE_GOODS)
		.value("YIELD_LUXURY_GOODS", YIELD_LUXURY_GOODS)   //melcher  new resource
		.value("YIELD_CULTURE", YIELD_CULTURE)   //melcher  new resource
		.value("YIELD_HAMMERS", YIELD_HAMMERS)
		.value("YIELD_BELLS", YIELD_BELLS)
		.value("YIELD_CROSSES", YIELD_CROSSES)
		.value("YIELD_EDUCATION", YIELD_EDUCATION)

Gold and Luxury goods are trade goods. Culture is just a placeholder yield at the moment. It's supposed to be a special yield which contol border expansion in the future. Maybe there is a problem with yields that do nothing?
The xml should be fine. Added all three yield in the right place and units for the first two.

[raystuttgart]

Hi melcher,

was die Advisor-Screens angeht, dass dort die letzten Icons fehlen:

Das hat NICHTS mit den Gamefonts zu tun !
Das liegt einfach daran, dass deine Liste an Yields jetzt länger ist.
Da musst du ins Python um das gerade zu biegen.

Ausserdem ganz ganz wichtig, dass du deinen neuen Yield "Culture" in der DLL richtig verbaust !

Denk an die AI-Regeln !
Die AI muss wissen, wie sie mit einem Yield umgeht.

-> Ansonsten sind dir CTDs im Spiel praktisch sicher !!!!

So wie das im Moment aussieht hast du da noch EINIGES nicht gemacht.
(Ausser natürlich du hast nicht alle Änderungen gepostet.)

[raystuttgart]

Hi melcher,

ich hänge dir mal meine Gamefonts von RWL an.
In denen habe ich alle Probleme, die mir aufgefallen sind gelöst.

1.) Yields alle korrekt
2.) Special-Buildings alle korrekt
3.) Missionierungskreuze
4.) Icons "Amerikanische Flagge", "Defense", ... korrekt
5.) Civilopedia und andere kleine Icons
6.) Trade-Route System

Vielleicht hilft es dir.

Ich saß da in den letzten 2 Tagen auch noch eine Weile dran, aber irgendwann hat man eigentlich alle Fehler ausgemerzt.
(Einfach am Ball bleiben, irgendwann hat man es dann. )

[melcher kürzer]

Hi melcher,

was die Advisor-Screens angeht, dass dort die letzten Icons fehlen:

Das hat NICHTS mit den Gamefonts zu tun !
Das liegt einfach daran, dass deine Liste an Yields jetzt länger ist.
Da musst du ins Python um das gerade zu biegen.

Ausserdem ganz ganz wichtig, dass du deinen neuen Yield "Culture" in der DLL richtig verbaust !

Denk an die AI-Regeln !
Die AI muss wissen, wie sie mit einem Yield umgeht.

-> Ansonsten sind dir CTDs im Spiel praktisch sicher !!!!

So wie das im Moment aussieht hast du da noch EINIGES nicht gemacht.
(Ausser natürlich du hast nicht alle Änderungen gepostet.)

Hey ray,
das mit den Advisor-Screens ist schonmal gut zu wissen. Werde mich in den ganzen python und .dll krempel eh erstmal richtig einarbeiten müssen.

Wie geschrieben, das Yield "Culture" macht im Moment erstmal gar nichts und ist nur ein Platzhalter. Es kann auch noch nicht produziert werden im Spiel und existiert somit eigentlich noch nicht.
Das da noch einiges fehlt ist mir klar. Scheint aber in dem Zustand keine größeren Probleme zu machen, ich habe gestern nebenbei die KI zweimal je 300 Runden spielen lassen. Keinerlei Absturz oder Probleme.

[raystuttgart]

Wie geschrieben, das Yield "Culture" macht im Moment erstmal gar nichts und ist nur ein Platzhalter. Es kann auch noch nicht produziert werden im Spiel und existiert somit eigentlich noch nicht.
Das da noch einiges fehlt ist mir klar. Scheint aber in dem Zustand keine größeren Probleme zu machen, ich habe gestern nebenbei die KI zweimal je 300 Runden spielen lassen. Keinerlei Absturz oder Probleme.

Die Fehler treten erst dann auf, wenn die AI mal so einen Yield in die Finger bekommt.
Solange die bei dir noch nicht im Spiel richtig auftauchen, bis du noch auf der sicheren Seite.
Aber sobald du einen Yield komplett einführst muss das alles da sein.

Beispiel:
Du hast eine Bonus-Ressource "Gold", die mittels Beruf "Goldgräber" die Ware Gold ermöglicht.
Sobald die KI dann zum allerersten Mal den Beruf Goldgräber nutzt und du der KI nicht gesagt hast, was sie dann mit Gold macht. -> CTD

[KJ_Jansson]

Hi melcher kürzer!

OK, I expected the same result.

Now the first approximation. I used the short version of GameFonts and just shifted all icons 1 line down.

Please, check the [ICON_BULLET] and strength icons as it shown on your previous screen. I hope they should be OK now.

Added:

- In the advisor screen the last yield is missing (diamond) under production and warehouse.

Should work also, but some changes in xml and Python are required. I have to read your and ray's discussion. Maybe you already found solution of this problem....

[melcher kürzer]

Die Fehler treten erst dann auf, wenn die AI mal so einen Yield in die Finger bekommt.
Solange die bei dir noch nicht im Spiel richtig auftauchen, bis du noch auf der sicheren Seite.
Aber sobald du einen Yield komplett einführst muss das alles da sein.

Beispiel:
Du hast eine Bonus-Ressource "Gold", die mittels Beruf "Goldgräber" die Ware Gold ermöglicht.
Sobald die KI dann zum allerersten Mal den Beruf Goldgräber nutzt und du der KI nicht gesagt hast, was sie dann mit Gold macht. -> CTD

Der Goldgräber war bei den Tests schon drin. Und da es im Moment überall auf Grasland Gold gibt und ich auch gesehen hab das die KI Gold produziert, denke ich mit Handelswaren ist das nicht so das Problem.

[raystuttgart]

Der Goldgräber war bei den Tests schon drin. Und da es im Moment überall auf Grasland Gold gibt und ich auch gesehen hab das die KI Gold produziert, denke ich mit Handelswaren ist das nicht so das Problem.

Hm, dann hast du vielleicht Glück, dass die "Default-Cases" einen CTD verhindern... verlass dich da aber nicht darauf.

...
case YIELD_HAMMERS:
case YIELD_BELLS:
case YIELD_CROSSES:
case YIELD_EDUCATION:
	break;
default:
	FAssert(false);

Es ist viel besser der KI genau zu sagen, was sie machen soll:

1. Wird die Ware weiterverarbeitet
2. Wird die Ware verkauft
3. Wird die Ware auch gekauft
4. Welche Priorität hat die Ware
...

[melcher kürzer]

Hi melcher kürzer!

OK, I expected the same result.

Now the first approximation. I used the short version of GameFonts and just shifted all icons 1 line down.

Please, check the [ICON_BULLET] and strength icons as it shown on your previous screen. I hope they should be OK now.

Awesome! That gamefont works perfectly.
The specialbuildings aren't displayed correctly, but this is only a minor issue.
I think they need to be one line below too. I should be able to fix that myself.

- In the advisor screen the last yield is missing (diamond) under production and warehouse.

Should work also, but some changes in xml and Python are required. I have to read your and ray's discussion. Maybe you already found solution of this problem....

As long as this is no gamefont problem anything is fine. I'll fix this in python then.

...
Es ist viel besser der KI genau zu sagen, was sie machen soll:

1. Wird die Ware weiterverarbeitet
2. Wird die Ware verkauft
3. Wird die Ware auch gekauft
4. Welche Priorität hat die Ware
...

Okay, gut zu wissen. Wie gesagt, ich seh mir das alles noch genauer an. Ich meld mich dann bei dir wenn ich irgendwo fragen habe.

[KJ_Jansson]

Awesome! That gamefont works perfectly.

Great!

The specialbuildings aren't displayed correctly, but this is only a minor issue.
I think they need to be one line below too. I should be able to fix that myself.

As long as this is no gamefont problem anything is fine. I'll fix this in python then.

I don't recommend to change your GameFonts because you problem with SpecialBuildings is not related to them.

You wrote

I think they need to be one line below too.

In such case you cannot see your SpecialBuildings at all! No one! If this is so (rather strange, but why not?) I will make all corrections for you.

Next steps:
- add your SPECIALBUILDING_LUXURY_GOODS and SPECIALBUILDING_CULTURE in the CIV4SpecialBuildingInfos.xml file.
- check carefully <FontButtonIndex> for both new SpecialBuildings,
(P.S. a propos, SPECIALBUILDING_LUXURY_GOODS is absent at all),
- edit the width of colums in CvDomesticAdvisor.py file, if you cannot see last icons.

Do not hesitate contact me if you need some corrections in your GameFonts.

[melcher kürzer]

Great!

I don't recommend to change your GameFonts because you problem with SpecialBuildings is not related to them.
...
In such case you cannot see your SpecialBuildings at all! No one! If this is so (rather strange, but why not?) I will make all corrections for you.

I only see this blubber bottle icon from TAC under buildings in the advisor screen. But that one is and was always there. It's obvious the game uses the icon from the yields line for that.

Next steps:
- add your SPECIALBUILDING_LUXURY_GOODS and SPECIALBUILDING_CULTURE in the CIV4SpecialBuildingInfos.xml file.
- check carefully <FontButtonIndex> for both new SpecialBuildings,
(P.S. a propos, SPECIALBUILDING_LUXURY_GOODS is absent at all),
- edit the width of colums in CvDomesticAdvisor.py file, if you cannot see last icons.

Do not hesitate contact me if you need some corrections in your GameFonts.

I will make the new yields fully funtcional during the next week. I won't change anything in the gamefont before then. Afterwards i will check if the specialbuildings are still broken. Then we can decide if it's necessary to change the gamefont again.

[raystuttgart]

I only see this blubber bottle icon from TAC under buildings in the advisor screen. But that one is and was always there. It's obvious the game uses the icon from the yields line for that.

Yes, that has been implemented by me.
It is especially coded for Whale_Oil to take the Icon from its Yield because there had been a bug.
(Now I know that I could have fixed it differently and will do that in RWL.
At that point I did not know a better way to fix the bug.)

The Icon is NOT taken from Special-Buildings line but from Yields-Line !

[KJ_Jansson]

I only see this blubber bottle icon from TAC under buildings in the advisor screen. But that one is and was always there. It's obvious the game uses the icon from the yields line for that.

Yes, that has been implemented by me.
It is especially coded for Whale_Oil to take the Icon from its Yield because there had been a bug.
(Now I know that I could have fixed it differently and will do that in RWL.
At that point I did not know a better way to fix the bug.)

The Icon is NOT taken from Special-Buildings line but from Yields-Line !

Well, well....

I see the GameFonts became more and more tricky. In future I have to take into account not only Firaxis work, but also some possible modding changes.

Couple months of such work and I could read The Phaistos Disc as fast as I read my morning newspapers.

[raystuttgart]

Well, well....

I see the GameFonts became more and more tricky. In future I have to take into account not only Firaxis work, but also some possible modding changes.

Couple months of such work and I could read The Phaistos Disc as fast as I read my morning newspapers.

Yeah I coded a lot of stuff in TAC in could do better today.

At the time when I implemented the Feature Whaling I simply did not understand Gamefonts as I do today.

There was this bug in Advisor-Screen "Building" and I had to fix it, so I did it they way I could.
-> I made some special Python-Logic for that Building.

However this Logic ONLY affects the one Special-Building for Whale-Oil.
All other Icons / Special-Buildings are not affected !